Regular crashing

[MBiddiscombe]

Almost every time I use OBS it crashes at least once (and more likely twice or more) on me.
* At startup, there's about a 25% chance of it crashing
* If I switch scene collections, there's about a 50% chance of it crashing
* If I try to remove a scene collection, there's about a 75% chance of it crashing

It seems to have got noticeably more likely to crash over the last month or so. I'd say that 2-3 months ago it was rock solid. Then I started seeing occasional crashes, but now it's reached the point that I expect it to crash several times during an evening when I'm preparing to run a live-stream. It was probably around that the time I started seeing crashes that I also had started to use OBS's Lua integration. When I've looked at the crash reports, the thread that's crashed is pretty consistently in the Lua-handling code.

Fortunately those crashes are (so far) while I'm preparing to run a live-stream, rather than during the stream itself.

Here's the log file from the second-to-last time it crashed on me, which was switching scene collections. https://obsproject.com/logs/09E_sQfBrUiAJPTE. I've attached the associated crash report to the post, because I forgot to "upload" it.

Here's the log file from the last time it crashed on me (just a few minutes after the previous crash), which was removing a scene collection. https://obsproject.com/logs/mx2fqq5PyicqyZOL, and here's the associated crash report: https://obsproject.com/logs/1Fo2lL53OUNZ4asO

 

[R1CH]

Do you have any Lua script loaded?

 

[MBiddiscombe]

Yes. One. transformer.lua (https://obsproject.com/forum/resources/transformer.814/)

 

[MBiddiscombe]

Just did it again (removing a scene collection). https://obsproject.com/logs/zoa-SxyzwW4kqYjA

 

[MBiddiscombe]

And again (twice so far today - once removing a scene collection, once switching scene collections). Here's the crash report from the second of those (switching scene collections). https://obsproject.com/logs/XXy8HXQUIvtZkrtc

As almost always, it's in (and indeed, close to the start of) get_context_by_name called from obslua dll. Looking at https://github.com/obsproject/obs-studio/blob/master/libobs/obs.c, it seems likely that a function in obslua.dll must be calling get_context_by_name with vfirst = NULL:

static inline void *get_context_by_name(void *vfirst, ...)
{
struct obs_context_data **first = vfirst;
...
context = *first; // first is dereferenced, it could be NULL.

Seems like checking [v]first is non-NULL would be advisable here.

 

[MBiddiscombe]

Twice again this evening - both times while trying to remove a scene collection, and both times in get_context_by_name called from obslua.dll.

https://obsproject.com/logs/hJrmGCN5kXng46JX

https://obsproject.com/logs/Eo-fnQPKP4c4EJZN