Bug Report Minor issue with game capture

[NoSFeRaTU]

If starcraft 2 running in fullscreen, not the fullscreen windowed. After closing obs and starting again it doesn't capture anymore (and sometimes leeds to freezing both) until both obs and starcraft completely close.
It doesn't happen when starcraft 2 in fullscreen windowed mode for me tho.

PS. Version is 0.466a. It's happening with another fullscreen games, Call of Duty: Modern Warfare (the first one) for example.

 

[Lain]

Thank you for the information. I will test starcraft a few times and see if I missed something.

 

[NoSFeRaTU]

Seems like it isn`t fixed yet... This helps me btw:

--- GraphicsCapture.orig/GraphicsCaptureHook/D3D9Capture.cpp    2013-02-26 22:12:36.000000000 +0400
+++ GraphicsCapture/GraphicsCaptureHook/D3D9Capture.cpp 2013-02-26 22:12:17.000000000 +0400
@@ -655,7 +655,7 @@
         bStopRequested = false;
     }

-    if(!bCapturing && WaitForSingleObject(hSignalRestart, 0) == WAIT_OBJECT_0)
+    if(WaitForSingleObject(hSignalRestart, 0) == WAIT_OBJECT_0)
     {
         hwndOBS = FindWindow(OBS_WINDOW_CLASS, NULL);
         if(hwndOBS)

 

[Lain]

I admittedly never got around to testing it, so many other things keep popping up left and right and I end up losing track of things in a pile of things to do.

But actually thanks to the code you posted I see what the real problem is. The game doesn't get the shutdown signal and it's left in the capturing state with the invalid window handle. I'll have to fix this by making sure it does some keep-alive checks, thank you very much for pointing this oversight out. Wish more people spoke in code

 

[NoSFeRaTU]

I admittedly never got around to testing it, so many other things keep popping up left and right and I end up losing track of things in a pile of things to do.

There are no problems, you are doing excelent job on improving the software and this minor issue is a pain only when obs crashes or was accidentially closed in the middle of the match so it is not possible to restart the game immediately.

But actually thanks to the code you posted I see what the real problem is. The game doesn't get the shutdown signal and it's left in the capturing state with the invalid window handle. I'll have to fix this by making sure it does some keep-alive checks, thank you very much for pointing this oversight out. Wish more people spoke in code

Thank you for the open sources of the project in the first place, that wouldn't be possible without that.