would you merge jack support?

[buscher]

Hi,
I have a basically working jack support implemented and running. I wonder if you would accept a generally pull request (after some cleanup&fine-tuning). Or if you do not want the burden of carrying it?

Its optional and works fine alongside pulseaudio.

So I am just asking if I would waste my time if I continue to develop it :)
I am using it as I do not have pulseaudio on my system, so for me (vanilla) obs-studio is rather useless.

Cheers

 

[Lain]

I personally have no objections to it, I'd like to see it first though of course, feel free to either link the branch comparison or make a pull request. Like any other open source project we don't merge code without reviewing it first.

 

[buscher]

Great to hear, as said its not yet really for a pull request(so looking at it now would just be a waste of time), but I will clean it up as soon as I find the time :)

 

[dodgepong]

Make sure it conforms to the contribution guidelines to save time during review: https://github.com/jp9000/obs-studio/blob/master/CONTRIBUTING

 

[buscher]

https://github.com/jp9000/obs-studio/pull/345
created, feel free to review the heck out of it :)