Check for file changes on images

[duilio1337]

I would like to see the option to check for file changes to images like obs classic currently has. Saw this requested about a year ago and was wondering if there has been any progress on this.

 

[Lain]

It should already have that feature.

 

[duilio1337]

https://www.youtube.com/watch?v=X09OexnhOX8

It seems that if I copy one image over another obs doesn't detect it. I played around with it a bit more and the only pattern I could see was sRGB images were more likely to work. All images are jpegs. Tried with pngs as well, same result.

 

[Lain]

But your image is PNG. Give me two files that I can test overwriting with. First file, and second file you overwrite the first file with.

 

[duilio1337]

I'm having trouble using the site attachments.

All of the images I'm using on obs are JPGs like these.

 

[Lain]

Ah I think I see the problem. It checks the timestamp of the file, and if the timestamp is *greater* than the old timestamp it reloads the file. I think what you're doing is overwriting a newer file with an older file, so it bypasses the check for that reason. I should be able to fix it to just check for a changed timestamp rather than a newer file timestamp.

 

[duilio1337]

That makes a lot of sense. Thanks for the help Jim.

 

[duilio1337]

Bumping to see if there is an expected date for this to be fixed.

 

[RytoEX]

Bumping to see if there is an expected date for this to be fixed.

I've gone ahead and made this change in code and made a pull request for Jim to review.
https://github.com/jp9000/obs-studio/pull/617

If he accepts it, then it will hopefully be in the next release. No promises! Jim might ask for changes or something completely different. We'll see.

 

[RytoEX]

https://github.com/jp9000/obs-studio/commit/1946ee644374adc5c2e3467177793dbb0eb9f1d0
https://github.com/jp9000/obs-studio/commit/c8a81bba7255362efff16d6be53d937ff1bf8066

Merged into OBS Studio. Looks like this will be available in the next release. Thanks Jim!

Caveat: I think that overwriting or copying files to a common filename will still have this issue if different files with exactly the same modified timestamp are copied in sequence one right after the other. This issue may also still arise if the file is overwritten, but the modified timestamp does not change. I have not tested these edge-cases. Baby steps.

 

[duilio1337]

Seems to be working just fine for me now. Thanks guys.